GitHub source: https://github.com/KantaraInitiative/SAMLprofiles/tree/master/edit/saml2int
...
| Reporter | Issue | Submitter Comments | Response(s) | Disposition | |
|---|---|---|---|---|---|
| 1 | Rainer Hoerbe | NA | The first paragraph in the introduction should contrast the deployment profile with an implementation profile, and reference the SAML Implementation Profile for Federation Interop for this purpose. The difference between both types of profiles is not widely understood. | Sounds sensible to the group. Slot in after first paragraph of introduction. Nick volunteers to propose language. | |
| 2 | Rainer Hoerbe | SDP-MD02 | I do not understand the explanation for [SDP-MD02]. If PKI with path validation is being used, there would be no hindrance to roll out new keys, even if metadata and assertions use the same key. I have seen a IDPs that publish their own metadata and the well-know location using the same signing key as for assertions. | (Scott) I think you may be correct about that and that the text is written with a presumption of the verification approach, and if we didn't specify that (and I don't think we did), it's open to methods that wouldn't have the problem we were concerned about. I think it needs work. Good catch. In a closed environment where you have control of the trust anchors, this would work. You could obtain metadata signing keys from a federation and publish signed metadata locally. This is correct in theory but not in practice - PKI doesn't federate beyond a closed ecosystem. We are trying to leave too much open, need to say how you trust the signature. Need to give a couple of examples, in this example the key would have to be different, in this one, the key would be the same. It's the binding of the key to the entity that's the problem with the model Rainer is talking about. The qualifier in the italicized text in MD02 is what we need to pull up into a positive requirement. | |
| 3 | Rainer Hoerbe | SDP-SP03 | "This will typically imply that requests do _not_ involve a full-frame redirect ..“. In my understanding it is the other way round; in Javascript terms one has to execute "document.location = url;" Also, what is the approach for single page applications? | (Scott) Ouch. Yeah, that's backwards. (re: SPA): Generally AJAX use has to be governed by more intelligent server side signaling and code able to detect a loss of session without being inadvertently thrown into a SSO loop, and that's not even just due to framing but simply the lack of a UI to handle the redirect when it happens at the wrong time. We'll fix the backwards part. | |
| 4 | Rainer Hoerbe | SDP-SP23 | I think that the division of IDP-discovery into disco-UI and preference persistence is a significant improvement over the current IDP-Discovery spec, fixing the issue that embedded discovery results are not shared across SPs. See the RA21-proposal: https://groups.niso.org/apps/group_public/download.php/21376/NISO_RP-27-2019_RA21_Identity_Discovery_and_Persistence-public_comment.pdf. Rumor has it that Leif implemented it in pyFF. | (Scott) The discovery spec that's referencing never addressed UI or persistence, it's an interop protocol only, to enable a discovery solution to be injected into the flow, whatever solution it might be. | |
| 5 | François Kooman | SDP-ALG01 | I'm trying to understand the RSA-OAEP encryption requirements for IdPs / SPs.
It seems most IdPs use SHA1 for both the MFG1 and digest? So, this profile requires you to use SHA1 for the MFG1 and SHA256 for the digest. Any reason why it is not SHA256 for both? Also, why not require MGF1 with SHA256: Probably I am missing something here... (Github Issue #129) | (Judith) I read the parenthesized reference to the default mask generation function to be a reiteration of a requirement stated elsewhere, particularly XMLEnc's §5.4.2 statement that "As described in the EME-OAEP-ENCODE function RFC 2437 [PKCS1, section 9.1.1.1], .... using the mask generator function MGF1 (with SHA1) specified in RFC 2437." If i am correct, i wonder if rewording as follows would be more clear
(Scott) There is definitely clarification needed, it reads very badly now...but most IdPs have long since stopped using SHA-1 for general usage, the MGF1 case is an exception and was left as is for interoperability. It's not that unusual for libraries to lack support for any MGF pluggability. If there are security implications for use of SHA-1 there, I'm not aware of them. |